Make diff view full width again #24598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
lunny
approved these changes
May 9, 2023
GiteaBot
added
lgtm/need 1
HesterG
approved these changes
May 9, 2023
GiteaBot
removed
the
lgtm/need 1
HesterG
approved these changes
May 9, 2023
GiteaBot
added
the
lgtm/done
wolfogre
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 9, 2023
* upstream/main: Add Gitea Profile Readmes (go-gitea#23260) Make diff view full width again (go-gitea#24598) Add permission check for moving issue action in project view page (go-gitea#24589) Update JS dependencies, add new eslint rules (go-gitea#24597) Filters for GetAllCommits (go-gitea#24568) [skip ci] Updated translations via Crowdin Attach a tooltip to the action control button (go-gitea#24595) Improve Gitea's web context, decouple "issue template" code into service package (go-gitea#24590) Support markdown editor for issue template (go-gitea#24400) Do not select line numbers when selecting text from the action run logs (go-gitea#24594) In TestViewRepo2, convert computed timezones to local time (go-gitea#24579) Fix close org projects (go-gitea#24588) Rewrite queue (go-gitea#24505) Split "modules/context.go" to separate files (go-gitea#24569) Pass 'not' to commit count (go-gitea#24473) Refresh the refernce of the closed PR when reopening (go-gitea#24231)
HesterG
reviewed
May 10, 2023
| @@ -1,8 +1,8 @@ | |||
| {{template "base/head" .}} | |||
| <div role="main" aria-label="{{.Title}}" class="page-content repository diff {{if .PageIsComparePull}}compare pull{{end}}"> | |||
| {{template "repo/header" .}} | |||
| <div class="ui container fluid padded"> | |||
There was a problem hiding this comment.
Just found that for this page, the widths of containers are different now, maybe we should still keep the fluid padded classes here (need to open another PR if this should be added back)?
There was a problem hiding this comment.
That's done by purpose: "And this PR also make the "create new PR form" not that wide"
Otherwise the "form" will be too wide.
ps: I agree that the UI doesn't look good, but it didn't look good before either ...
So, it needs some better designs.
There was a problem hiding this comment.
Github does not use wider width for these pages(diff and new pr), maybe we can do the same? remove the fluid on these two pages.
dff page:
new pr page:
There was a problem hiding this comment.
Good point, then we can make this page narrow.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression of #24459 , the related line
The PR file diff view needs to be full screen width.
And this PR also make the "create new PR form" not that wide